Fixed #35252 -- Optimized _route_to_regex(). #17908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezabelle
reviewed
Feb 26, 2024
adamchainz
commented
Feb 26, 2024
ngnpope
reviewed
Feb 28, 2024
|
Thanks for the review @ngnpope, I'll action it tonight. |
|
Alright, done tonight. @ngnpope would you mind accepting the ticket, since it seems you think the optimization is worthwhile and safe? |
co-authored-by: Nick Pope <nick@nickpope.me.uk>
felixxm
reviewed
Mar 5, 2024
|
|
||
| @functools.cache | ||
| def get_converters(): | ||
| return {**DEFAULT_CONVERTERS, **REGISTERED_CONVERTERS} | ||
|
|
||
|
|
||
| def get_converter(raw_converter): |
There was a problem hiding this comment.
I added a release note about removing this undocumented function.
django/urls/resolvers.py
Outdated
| break | ||
| elif not set(match.group()).isdisjoint(string.whitespace): | ||
| previous_end = 0 | ||
| for match in _PATH_PARAMETER_COMPONENT_RE.finditer(route): |
There was a problem hiding this comment.
Changed match to match_ to avoid using a keyword.
There was a problem hiding this comment.
Fair. It's a soft keyword deliberately to not break use of regexes like this, as I heard recently on https://podcasts.apple.com/gb/podcast/core-py/id1712665877?i=1000647675451 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket-35252