Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #35273 -- Fixed rendering AdminFileWidget's attributes. #17946

Merged
merged 2 commits into from Mar 14, 2024
Merged

Fixed #35273 -- Fixed rendering AdminFileWidget's attributes. #17946

merged 2 commits into from Mar 14, 2024

Conversation

codingjoe
Copy link
Sponsor Contributor

@codingjoe codingjoe commented Mar 6, 2024 •
edited

Trac ticket number

ticket-35273

Branch description

Provide a concise overview of the issue or rationale behind the proposed changes.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • For UI changes, I have attached screenshots in both light and dark modes.

@codingjoe codingjoe force-pushed the issues/35273 branch 5 times, most recently from d351480 to b36d108 Compare March 8, 2024 19:49
@codingjoe codingjoe marked this pull request as ready for review March 8, 2024 19:49
@timgraham timgraham added the selenium Apply to have Selenium tests run on a PR label Mar 9, 2024
@timgraham timgraham changed the title Fixed #35273 -- Prevent ID-attribute duplication Fixed #35273 -- Prevented id attribute duplication of AdminFileWidget. Mar 9, 2024
felixxm
felixxm reviewed Mar 12, 2024
View reviewed changes
docs/releases/5.0.4.txt Outdated Show resolved Hide resolved
felixxm
felixxm reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codingjoe Thanks 👍 I left comments.

@felixxm
Copy link
Member

felixxm commented Mar 14, 2024

@codingjoe Do you have time to keep working on this? If not, I can reorganize commits.

@felixxm felixxm changed the title Fixed #35273 -- Prevented id attribute duplication of AdminFileWidget. Fixed #35273 -- Fixed rendering AdminFileWidget's attributes. Mar 14, 2024
@felixxm
Copy link
Member

felixxm commented Mar 14, 2024

@codingjoe Thanks 👍

@felixxm felixxm merged commit 3d7235c into django:main Mar 14, 2024
35 checks passed
@codingjoe
Copy link
Sponsor Contributor Author

@codingjoe Thanks 👍

Thanks @felixxm I appreciate the help <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm left review comments

Assignees
No one assigned
Labels
selenium Apply to have Selenium tests run on a PR
Projects
None yet
Milestone
No milestone
3 participants
@codingjoe @felixxm @timgraham