-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #34618 -- Added icon descriptions in "Recent Actions" on the admin index. #16917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. 👍
Could we add tests to show that the html generated when this template is used?
Hi, Just to avoid linting and formatting errors you can set up pre commit checks. See here for instructions. |
@DevilsAutumn as far as I can see there are no pre-commit checks for CSS. Be great to add some? |
It was for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 all working as expected in desktop Safari VoiceOver.
@nmenezes0 Do you have time to keep working on this? I only left reformatting suggestions. |
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Yes, I have time to keep working on this today and will make the suggested changes. |
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
@nmenezes0 Thanks 👍 Welcome aboard ⛵ You're a Django contributor no. 2400 🥳 |
Have made those formatting changes and checked they are ok locally. |
Fixes https://code.djangoproject.com/ticket/34618