Fixed #28344 -- Allowed customizing queryset in Model.refresh_from_db()/arefresh_from_db(). #17592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aivarsk
force-pushed
the
ticket_28344
branch
from
f0d2ef8
to
3790398
Compare
aivarsk
changed the title
kezabelle
reviewed
Dec 12, 2023
aivarsk
force-pushed
the
ticket_28344
branch
from
3790398
to
0d71781
Compare
ngnpope
reviewed
Dec 14, 2023
aivarsk
force-pushed
the
ticket_28344
branch
from
6fdb0f6
to
d01b2ad
Compare
charettes
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
Thank you for committing to this patch @aivarsk, this is looking great!
I don't have anything to add really, the fact select_related is also tested and that the documentation includes examples of how it can be relied on to exclude rows and lock them. Seing the patch completed reinforces my believe that this is going to be useful for more than just row locking like it was intentionally intended.
Approving assuming the release note message is adjusted.
felixxm
changed the title
kezabelle
reviewed
Jan 15, 2024
…()/arefresh_from_db(). The from_queryset parameter can be used to: - use a custom Manager - lock the row until the end of transaction - select additional related objects
|
@aivarsk Thanks for this patch 👍 Welcome aboard ⛵ I added support for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The from_queryset parameter can be used to:
from_queryset=Model.active_objects.all()
from_queryset=Model.objects.select_for_update()
from_queryset=Model.objects.select_related('related_field')