Fixed #35090 -- Deprecated registering URL converters with the same name. #17703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
changed the title
|
THank you for the work, though the ticket is not accepted yet. I think we should wait to see some input from others to accept it. One change that your PR will require is using the deprecation policy. We would need to warn at first, and then two versions later we can raise an exception. Read the policy and check out some recent PRs that have deprecated other features. |
salvo-polizzi
force-pushed
the
ticket_35090
branch
2 times, most recently
from
c4a2688
to
e82c59b
Compare
felixxm
reviewed
Jan 12, 2024
salvo-polizzi
force-pushed
the
ticket_35090
branch
from
e82c59b
to
5357484
Compare
felixxm
reviewed
Feb 22, 2024
salvo-polizzi
force-pushed
the
ticket_35090
branch
4 times, most recently
from
e7870c5
to
6b715af
Compare
adamchainz
suggested changes
Feb 22, 2024
salvo-polizzi
force-pushed
the
ticket_35090
branch
from
6b715af
to
82958df
Compare
|
Thanks @adamchainz for review |
shangxiao
reviewed
Feb 23, 2024
salvo-polizzi
force-pushed
the
ticket_35090
branch
from
82958df
to
5600f8c
Compare
shangxiao
reviewed
Feb 23, 2024
adamchainz
approved these changes
Feb 23, 2024
felixxm
changed the title
felixxm
force-pushed
the
ticket_35090
branch
from
5600f8c
to
6e1ece7
Compare
felixxm
reviewed
Feb 23, 2024
There was a problem hiding this comment.
@salvo-polizzi Thanks 👍 I pushed final edits 👍
@adamchainz @shangxiao Thanks for reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket 35090