Skip to content

Fixed #35646 -- Extended SafeExceptionReporterFilter.hidden_settings to treat AUTH as a sensitive match. #18433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2024
Merged

Fixed #35646 -- Extended SafeExceptionReporterFilter.hidden_settings to treat AUTH as a sensitive match. #18433

merged 2 commits into from
Aug 1, 2024
+49 −34

Conversation

nessita
Copy link
Contributor

@nessita nessita commented Jul 31, 2024

Trac ticket number

ticket-35646

Branch description

Harden the filtering of settings and meta values during error reporting.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.

Sorry, something went wrong.

@nessita nessita force-pushed the fixed-35646-SafeExceptionReporterFilter-hardening branch from 020ece7 to 8543e7a Compare July 31, 2024 19:00
@nessita nessita requested review from adamchainz and a team July 31, 2024 19:55
claudep
claudep approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

nessita and others added 2 commits August 1, 2024 11:29
@nessita
Improved view_tests.tests.test_debug.ExceptionReporterFilterTests.
2d932a4
@MarkusH @nessita
Fixed #35646 -- Extended SafeExceptionReporterFilter.hidden_settings …

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
Loading
Loading status checks…
d3a0bc6 
…to treat `AUTH` as a sensitive match.

Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
@nessita nessita force-pushed the fixed-35646-SafeExceptionReporterFilter-hardening branch from 8543e7a to d3a0bc6 Compare August 1, 2024 16:03
sarahboyce
sarahboyce approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nessita nessita merged commit aa90795 into django:main Aug 1, 2024
36 checks passed
@nessita nessita deleted the fixed-35646-SafeExceptionReporterFilter-hardening branch August 2, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtylerwalls jacobtylerwalls

@claudep claudep

@sarahboyce sarahboyce

@adamchainz adamchainz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nessita @claudep @jacobtylerwalls @sarahboyce @MarkusH