feature: allow WireUpControls to find View members #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @Qonstrukt. It's a 👍 from me. Can one of our @reactiveui/reviewers-android reviewers review as well. Looking to get this in |
kentcb
reviewed
Jan 7, 2017
| @@ -78,7 +78,7 @@ public static T GetControl<T>(this Fragment This, [CallerMemberName]string prope | |||
| public static void WireUpControls(this ILayoutViewHost This) | |||
| { | |||
| var members = This.GetType().GetRuntimeProperties() | |||
| .Where(m => m.PropertyType.IsSubclassOf(typeof(View))); | |||
There was a problem hiding this comment.
Can you please change all these to use IsAssignableFrom:
.Where(m => typeof(View).IsAssignableFrom(m.PropertyType)))There was a problem hiding this comment.
Sure, that should be no problem. I choose for this solution because of a post I saw with some good points on SO: http://stackoverflow.com/a/2742288.
But I don't think the false positives are a problem here because we're not using value-type comparisons.
Qonstrukt
force-pushed
the
wire-up-views
branch
from
62a94d6
to
991fc02
Compare
|
lgtm. Thanks @Qonstrukt! 👍 |
ghuntley
changed the title
3 tasks
3 tasks
ghuntley
pushed a commit
that referenced
this pull request
Jan 31, 2017
glennawatson
pushed a commit
that referenced
this pull request
Mar 23, 2019
glennawatson
pushed a commit
that referenced
this pull request
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This will allow
WireUpControls()to wire up View properties, and not just subclasses of it.What is the current behavior? (You can also link to an open issue here)
WireUpControls()doesn't currently wire up View properties, just subclasses.What is the new behavior (if this is a feature change)?
WireUpControls()now also wires up View properties.Does this PR introduce a breaking change?
It shouldn't, unless you were expecting
nullvalues on your View properties. If you were working around this with manualFindViewByIdcalls you're assigning the same view twice to the same property, worst-case. (Considering you weren't using duplicate names for views or controls in the first place.)Please check if the PR fulfills these requirements
Other information: