Fixed #35392 -- Allowed importing aprefetch_related_objects from django.db.models. #18091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
jlost
force-pushed
the
import-aprefetch-rel-objs
branch
3 times, most recently
from
2ba7808
to
ff3f202
Compare
timgraham
changed the title
aprefetch_related_objects import to django.db.models
timgraham
approved these changes
Apr 20, 2024
…cts from django.db.models. Thanks James Ostrander for the report and fix, and to Tim Graham and Mariusz Felisiak for the reviews.
nessita
force-pushed
the
import-aprefetch-rel-objs
branch
from
4455077
to
3b616b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-35392
Branch description
aprefetch_related_objectscannot be imported fromdjango.db.modelslikeprefetch_related_objectscan. Because the docs say nothing about importing the async version from a different place, I believe this to be an oversight.You can work around this by importing from
django.db.models.querybut if that's the intended behavior, the documentation should be updated to reflect that. Let me know and I'll do so happily!Checklist
mainbranch.