Removed hard reference to StatusBar, changed to type name to prevent … #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…crash when StatusBar type is not present
|
👍 Also, congrats on being our first outside pull request! |
|
Ha! I was wondering if this would be the first. I saw the announcement on Twitter and a light bulb immediately appeared over my head |
|
@hartez I think you will have a lot of work on next weeks 😉 |
|
👍 |
|
|
|
Woooooooo |
|
XF is about to become freaking amazing! |
|
Hey the @thebeekeeper we forget to ask you to sign the CLA for being able to contribute, can you do it now using this link https://cla2.dotnetfoundation.org Thanks. |
|
@rmarinho signed it |
mattleibow
pushed a commit
that referenced
this pull request
Jan 28, 2021
* Change compass to event based. * Additional cleanup * Fixup compass on uwp to stop. * Put in dispose functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Modified calls to
ApiInformation.IsTypePresent()in WinRT Platform.cs to compile and run when theStatusBartype is not present.Bugs Fixed
https://bugzilla.xamarin.com/show_bug.cgi?id=40740
API Changes
None
Behavioral Changes
None
PR Checklist
…crash when StatusBar type is not present