Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run failed if the user is using an RSA key for SSH #197

Closed
Yorko opened this issue Feb 16, 2023 · 1 comment · Fixed by #198
Closed

Run failed if the user is using an RSA key for SSH #197

Yorko opened this issue Feb 16, 2023 · 1 comment · Fixed by #198
Assignees
@r4victor
Labels
bug Something isn't working

Comments

@Yorko
Copy link

Yorko commented Feb 16, 2023

Reproducing all steps described here for stable diffusion.

dstack run stable-diffusion takes just 7-10 secs. to finish

Once you run it, dstack will run the script, and save the models folder as an artifact. After that, you can reuse it in other workflows.

This doesn't happen.

dstack ps shows that the run is failed although no logs are anywhere to be seen.

Here are the contents of the ~/.dstack/tmp/runner/configs folder.

Tested with both Mac OS X 11.7 with Python 3.10.9 and dstack 0.1 and Ubuntu 20.04.5 LTS with Python 3.8.10 and dstack 0.1
@peterschmidt85 peterschmidt85 transferred this issue from dstackai/dstack-examples Feb 16, 2023
@r4victor r4victor self-assigned this Feb 17, 2023
@r4victor r4victor added the bug Something isn't working label Feb 17, 2023
@r4victor
Copy link
Collaborator

The issue happens when using ssh-rsa keys for github auth. The runner prints:

time=2023-02-17T16:10:52+05:00 level=error msg=Failed run err=[executor.go:216 executor.(*Executor).runJob] [executor.go:325 executor.(*Executor).prepareGit] unknown error: ERROR: You're using an RSA key with SHA-1, which is no longer allowed. Please use a newer client or a different key type.

OpenSSH ended support for SHA-1 signatures ("ssh-rsa" signatures) but the keys should still work:

"ssh-rsa" keys are capable of signing using "rsa-sha2-256" (RSA/SHA256), "rsa-sha2-512" (RSA/SHA512)

The problem is that our current version of golang.org/x/crypto is not capable of that (go-git/go-git#516). The latest version is, so the update fixes the issue and ssh-rsa keys work.

@r4victor r4victor mentioned this issue Feb 17, 2023
Merged
@peterschmidt85 peterschmidt85 changed the title Failed run, no logs Run failed if the user is using an RSA key for SSH Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r4victor r4victor

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade golang.org/x/crypto dstackai/dstack
2 participants
@Yorko @r4victor