Fixed #35147 -- Added backward incompatibility note about filtering against overflowing integers. #17795
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
docs/releases/5.0.txt
Outdated
| * Due to a commit meant to address a SQLite crash and a DDOS vector on | ||
| Postgres, non-wrapped arithmetic against integer fields might require | ||
| adjustments, like explicit wrapping with ``ExpressionWrapper``, see | ||
| (:ticket:`35147`). |
There was a problem hiding this comment.
We don't refer ticket number in a feature release notes. Maybe:
| * Due to a commit meant to address a SQLite crash and a DDOS vector on | |
| Postgres, non-wrapped arithmetic against integer fields might require | |
| adjustments, like explicit wrapping with ``ExpressionWrapper``, see | |
| (:ticket:`35147`). | |
| * Filtering querysets against overflowing integer values now immediately | |
| returns an empty queryset. As a consequence, you may need to use | |
| ``ExpressionWrapper`` to :ref:`explicitly wrap <using-f-with-annotations>` | |
| arithmetic against integer fields in such cases. |
There was a problem hiding this comment.
Thanks for the comment Mariusz. I guess the referrence to a ticket are only for Bugfixes. I rewrite the note per your suggestion.
docs/releases/5.0.txt
Outdated
| @@ -588,6 +588,11 @@ Miscellaneous | |||
|
|
|||
| * The minimum supported version of ``docutils`` is increased to 0.19. | |||
|
|
|||
| * Filtering querysets against overflowing integer values now immediately | |||
There was a problem hiding this comment.
Maybe always 🤔
| * Filtering querysets against overflowing integer values now immediately | |
| * Filtering querysets against overflowing integer values now always |
There was a problem hiding this comment.
Ugh, yeah, it is always, indeed.
felixxm
changed the title
…gainst overflowing integers.
|
@Darbados Thanks 👍 Welcome aboard ⛵ |
|
Thanks for the patch both, think looks great! |
Thank you both for the support @felixxm and @charettes. |
No description provided.