Opened 11 months ago

Closed 10 months ago

#34688 closed Cleanup/optimization (fixed)

Remove contrib.sitemaps.ping_google().

Reported by: Andrew Northall Owned by: Andrew Northall
Component: contrib.sitemaps Version: 4.2
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Mariusz Felisiak)

​https://developers.google.com/search/blog/2023/06/sitemaps-lastmod-ping?hl=en

@ewjoachim has posted the above blog post by Google in the Django Discord which details that Google is depreciating the sitemap ping, and will remove it in 6 months time (end of January 2024).

This ping endpoint is used by contrib.django.sitemaps (ping_google() in __init__.py) and also has an associated management command which will require depreciation if Google are going to disable the endpoint.

Change History (8)

comment:1 by Mariusz Felisiak, 11 months ago

Triage Stage: Unreviewed → Accepted

comment:2 by Mariusz Felisiak, 11 months ago

Summary: contrib.sitemaps.ping_google() requires depreciation as the endpoint is being depreciated → Deprecate contrib.sitemaps.ping_google().

comment:3 by Andrew Northall, 11 months ago

Owner: changed from nobody to Andrew Northall
Status: new → assigned

I will work on this.

comment:4 by Andrew Northall, 11 months ago

Has patch: set

PR added.

​https://github.com/django/django/pull/17039

comment:5 by Mariusz Felisiak, 11 months ago

Description: modified (diff)
Patch needs improvement: set
Summary: Deprecate contrib.sitemaps.ping_google(). → Remove contrib.sitemaps.ping_google().

comment:6 by Andrew Northall, 10 months ago

Patch needs improvement: unset

PR updated to fully remove contrib.sitemaps.ping_google() and the ping_google management command without prior deprecation as per consensus on the Django forum.

comment:7 by Mariusz Felisiak, 10 months ago

Triage Stage: Accepted → Ready for checkin

comment:8 by Mariusz Felisiak <felisiak.mariusz@…>, 10 months ago

Resolution: → fixed
Status: assigned → closed

In 6d42728:

Fixed #34688 -- Removed contrib.sitemaps.ping_google() and ping_google management command.

Thanks Joachim Jablon for the report.

Google has deprecated the sitemap ping endpoint, and will be removing
it in 6 months ~January 2024.

Note: See TracTickets for help on using tickets.
Back to Top