New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SQS event integration #5074
Conversation
@@ -46,6 +46,7 @@ | |||
"./aws/package/compile/events/cloudWatchEvent/index.js", | |||
"./aws/package/compile/events/cloudWatchLog/index.js", | |||
"./aws/package/compile/events/cognitoUserPool/index.js", | |||
"./aws/package/compile/events/sqs/index.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering why this plugin wasn't running!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃檲 Yea, took me a while to find this one 馃榿
docs/providers/aws/events/sqs.md
Outdated
events: | ||
- sqs: | ||
arn: arn:aws:sqs:region:XXXXXX:myQueue | ||
batchSize: 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 is the maximum batch size allowed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexdebrie
Great to see working fine 馃帀 馃帀 馃帀
LGTM
This is awesome! Thanks for implementing this @alexdebrie 馃憤 馃帀 |
Any plans to implement the "Extended Client" functionality as in AWS Java SDK to support messages larger than 256kb by storing the payload/body on S3? E.g.:
|
What did you implement:
Adds SQS event integration 馃帀
How did you implement it:
EDIT 6/28: SQS integration is live! Full testing instructions below.
I saw Brett Andrews note that Lambda + SQS integration is coming soon. Then I peeked at the SAM implementation of the SQS event. It looks to be very similar to Kinesis / DynamoDB streams as it's a pull-based integration. Like the streams, you can set batch size. There is no need for the
startingPosition
parameter though.I found the necessary IAM permissions by looking at the permissions on this role.
How can we verify it:
We need to wait until the integration is actually released. Once it is, you could use the following
serverless.yml
to test:After you deploy, run the following commands with the
awscli
to put a message into your Queue:Then check to make sure your Lambda fired:
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO