Property wrapper for Firestore #8614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Friese <peter@peterfriese.de>
Signed-off-by: Peter Friese <peter@peterfriese.de>
…to FirestoreQuery, Rename several functions, attributes and parameter labels, Extend error handling
…Store to FirestoreQueryObservable, Rename some parameters, Remove setter for wrappedValue
…nge predicates & collectionPath
…opertywrapper Signed-off-by: Peter Friese <peter@peterfriese.de> # Conflicts: # Firestore/Swift/Source/PropertyWrapper/FirestoreQuery.swift
Signed-off-by: Peter Friese <peter@peterfriese.de>
Signed-off-by: Peter Friese <peter@peterfriese.de>
Signed-off-by: Peter Friese <peter@peterfriese.de>
|
@googlebot I consent. |
(Hint: this doesn't work) Signed-off-by: Peter Friese <peter@peterfriese.de>
Binary Size ReportAffected SDKsTest Logs
|
Signed-off-by: Peter Friese <peter@peterfriese.de>
Signed-off-by: Peter Friese <peter@peterfriese.de>
Signed-off-by: Peter Friese <peter@peterfriese.de>
Signed-off-by: Peter Friese <peter@peterfriese.de>
Signed-off-by: Peter Friese <peter@peterfriese.de>
Signed-off-by: Peter Friese <peter@peterfriese.de>
Signed-off-by: Peter Friese <peter@peterfriese.de>
Signed-off-by: Peter Friese <peter@peterfriese.de>
ncooke3
reviewed
Sep 24, 2021
Example/FirestoreSample/FirestoreSample/App/FirestoreSampleApp.swift
Outdated
Show resolved
Hide resolved
Firestore/Swift/Source/PropertyWrapper/FirestoreQueryObservable.swift
Outdated
Show resolved
Hide resolved
Firestore/Swift/Source/PropertyWrapper/FirestoreQueryObservable.swift
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Friese <peter@peterfriese.de>
ncooke3
reviewed
Sep 27, 2021
Firestore/Swift/Source/PropertyWrapper/FirestoreQueryObservable.swift
Outdated
Show resolved
Hide resolved
ncooke3
approved these changes
Sep 27, 2021
Signed-off-by: Peter Friese <peter@peterfriese.de>
|
API Request has been approved! |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #8408, including some explorations for error handling contributed by @mortenbekditlevsen.