Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #35329 -- Fixed migrations crash when adding partial unique constraints with nulls_distinct. #18022

Merged
merged 1 commit into from Mar 26, 2024
Merged

Fixed #35329 -- Fixed migrations crash when adding partial unique constraints with nulls_distinct. #18022

merged 1 commit into from Mar 26, 2024
+37 −1

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Mar 26, 2024

Bug in 595a2ab.

Thanks Lucas Lemke Saunitti for the report.

ticket-35329

@felixxm
Fixed #35329 -- Fixed migrations crash when adding partial unique con…
d358cb6 
…straints with nulls_distinct.

Bug in 595a2ab.

Thanks Lucas Lemke Saunitti for the report.
@felixxm felixxm requested a review from a team March 26, 2024 19:11
@nessita
Copy link
Contributor

nessita commented Mar 26, 2024

buildbot, test on oracle.

@felixxm
Copy link
Member Author

felixxm commented Mar 26, 2024

buildbot, test on oracle.

nulls_distinct is supported only on PostgreSQL 15+, there is no need to run tests on Oracle.

@nessita
Copy link
Contributor

nessita commented Mar 26, 2024

buildbot, test on oracle.

nulls_distinct is supported only on PostgreSQL 15+, there is no need to run tests on Oracle.

I know but since the changes are made to the base/schema.py, I wanted to triple check all tests pass OK.

@felixxm
Copy link
Member Author

felixxm commented Mar 26, 2024

buildbot, test on oracle.

nulls_distinct is supported only on PostgreSQL 15+, there is no need to run tests on Oracle.

I know but since the changes are made to the base/schema.py, I wanted to triple check all tests pass OK.

None of tests with nulls_distince will run on Oracle 🤷

@nessita
Copy link
Contributor

nessita commented Mar 26, 2024

buildbot, test on oracle.

nulls_distinct is supported only on PostgreSQL 15+, there is no need to run tests on Oracle.

I know but since the changes are made to the base/schema.py, I wanted to triple check all tests pass OK.

None of tests with nulls_distince will run on Oracle 🤷

I understand that, but the changed code will be used in systems using Oracle.

nessita
nessita approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@nessita nessita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@felixxm
Copy link
Member Author

felixxm commented Mar 26, 2024

Thanks for reviews 👍

@felixxm felixxm merged commit b98271a into django:main Mar 26, 2024
38 checks passed
@felixxm felixxm deleted the issue-35329 branch March 26, 2024 22:00
@lsaunitti
Copy link

Thank you guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charettes charettes charettes approved these changes

@nessita nessita nessita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@felixxm @nessita @lsaunitti @charettes