feature: added generic reactive controllers and views for iOS and Mac #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reactiveui/reviewers-ios and @reactiveui/reviewers-mac could you please have an 👁 of this for inclusion into ReactiveUI v7.1.0 (tomorrow?) |
|
lgtm. Thanks @Qonstrukt! |
ghuntley
changed the title
glennawatson
pushed a commit
that referenced
this pull request
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
I've added generic versions of every Reactive ViewController and View / Control on iOS and Mac to allow easier assignment of ViewModels with such classes.
We use these classes in all of our projects, and it's kind of cumbersome to copy them every time, or to create a special package.
It's also spoken of in #1029.
What is the current behavior? (You can also link to an open issue here)
You have to create/add these versions to all of your projects.
What is the new behavior (if this is a feature change)?
They're factory-installed!
Does this PR introduce a breaking change?
It shouldn't, since the non-generic versions are still there. I took the liberty of cleaning up unused usings though. But this is a case of "If it builds, it works."
Please check if the PR fulfills these requirements
Other information: