Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #34565 -- Added support for async checking of user passwords. #16855

Merged
merged 1 commit into from May 18, 2023
Merged

Fixed #34565 -- Added support for async checking of user passwords. #16855

merged 1 commit into from May 18, 2023

Conversation

HappyDingning
Copy link
Contributor

Add acheck_password method and its unit tests. This method will call the async setter function to update the password field of the user table when the settings.PASSWORD_HASHERS is changed.

github-actions[bot]
github-actions bot reviewed May 15, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

felixxm
felixxm reviewed May 15, 2023
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HappyDingning Thanks 👍 Please fix linter errors. Also, docs changes and release notes are missing. We should document User.acheck_password(), AbstractBaseUser.acheck_password(), and acheck_password().

@HappyDingning
Copy link
Contributor Author

HappyDingning commented May 17, 2023 •
edited

@felixxm Hello, I implemented the acheck_passport document by referring to the document in the ORM section. I previewed the document after making changes and saw a green line appearing in front of some paragraphs. I want to ask if I need to try another way of writing?
green_line

In addition, regarding the release document, which version of the document should I write in? 4.2.2 or 5.0?

Thank you.

@felixxm
Copy link
Member

felixxm commented May 17, 2023

@felixxm Hello, I implemented the acheck_passport document by referring to the document in the ORM section.

I'm not sure what acheck_passport() has to do with the ORM 🤔 Please submit doc updates and we will review.

I previewed the document after making changes and saw a green line appearing in front of some paragraphs. I want to ask if I need to try another way of writing? (Sorry, I have some problems here, I will upload pictures as soon as possible.)

There is no need to upload pictures, just submit doc changes and we will review.

In addition, regarding the release document, which version of the document should I write in? 4.2.2 or 5.0?

5.0

@HappyDingning
Copy link
Contributor Author

@felixxm Hello, I implemented the acheck_passport document by referring to the document in the ORM section.

I'm not sure what acheck_passport() has to do with the ORM 🤔 Please submit doc updates and we will review.

I previewed the document after making changes and saw a green line appearing in front of some paragraphs. I want to ask if I need to try another way of writing? (Sorry, I have some problems here, I will upload pictures as soon as possible.)

There is no need to upload pictures, just submit doc changes and we will review.

In addition, regarding the release document, which version of the document should I write in? 4.2.2 or 5.0?

5.0

Ok, thanks for your patient reply, I will upload the document as soon as possible

felixxm
felixxm reviewed May 17, 2023
View reviewed changes
docs/releases/5.0.txt Outdated Show resolved Hide resolved
@felixxm felixxm changed the title Refs #34565: Add acheck_password() async method Fixed #34565 -- Added support for async checking of user passwords. May 18, 2023
@felixxm
Copy link
Member

felixxm commented May 18, 2023

@HappyDingning Thanks 👍 Welcome aboard ⛵

I pushed small edits.

@HappyDingning
Copy link
Contributor Author

@HappyDingning Thanks 👍 Welcome aboard ⛵

I pushed small edits.

Thanks a lot for helping me optimize my code.😊 I will check for checks failure issues as soon as possible

@felixxm
Copy link
Member

felixxm commented May 18, 2023

Thanks a lot for helping me optimize my code.blush I will check for checks failure issues as soon as possible

No need, this test is flaky,

@felixxm felixxm merged commit 674c239 into django:main May 18, 2023
26 checks passed
@dingning-aspecta
Copy link

dingning-aspecta commented May 18, 2023 •
edited

Thanks a lot for helping me optimize my code.blush I will check for checks failure issues as soon as possible

No need, this test is flaky,

Thank you very much for your review and tidying up the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm left review comments

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@HappyDingning @felixxm @dingning-aspecta