Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #17905 -- Restricted access to model pages in admindocs to users with permissions. #18783

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fixed #17905 -- Restricted access to model pages in admindocs to users with permissions. #18783

merged 1 commit into from
Nov 11, 2024
+143 −7

Conversation

sai-ganesh-03
Copy link
Contributor

@sai-ganesh-03 sai-ganesh-03 commented Nov 7, 2024 •
edited
Loading

Trac ticket number

ticket-17905

Branch description

Admin documentation lists only the models that users have access to

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

Sorry, something went wrong.

sarahboyce
sarahboyce reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have some suggestions 👍

@sai-ganesh-03 sai-ganesh-03 force-pushed the 17905-Admin-documentation-lists-all-models-even-for-users-without-access-to-certain-applications branch from e77c89e to 4ee4842 Compare November 9, 2024 07:52
@sarahboyce sarahboyce changed the title Fixed #17905 -- admin documentation lists only the models that users have access to Fixed #17905 -- Restricted access to model pages in admindocs to users with model permissions. Nov 11, 2024
@sarahboyce sarahboyce changed the title Fixed #17905 -- Restricted access to model pages in admindocs to users with model permissions. Fixed #17905 -- Restricted access to model pages in admindocs to users with permissions. Nov 11, 2024
sarahboyce
sarahboyce reviewed Nov 11, 2024
View reviewed changes
@sai-ganesh-03 sai-ganesh-03 force-pushed the 17905-Admin-documentation-lists-all-models-even-for-users-without-access-to-certain-applications branch from 4ee4842 to 92c8a89 Compare November 11, 2024 14:35
@sai-ganesh-03 @sarahboyce
Fixed django#17905 -- Restricted access to model pages in admindocs.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
311804e 
Only users with view or change model permissions can access.
Thank you to Sarah Boyce for the review.
@sarahboyce sarahboyce force-pushed the 17905-Admin-documentation-lists-all-models-even-for-users-without-access-to-certain-applications branch from 92c8a89 to 311804e Compare November 11, 2024 14:58
sarahboyce
sarahboyce approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sai-ganesh-03 ⭐ this looks good to me

@sarahboyce sarahboyce merged commit c12bc98 into django:main Nov 11, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahboyce sarahboyce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sai-ganesh-03 @sarahboyce