Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #35058 -- Added support for measured geometries to GDAL Point. #17696

Merged
merged 1 commit into from Jan 25, 2024

Conversation

smithdc1
Copy link
Member

@smithdc1 smithdc1 commented Jan 5, 2024

Ticket

This PR adds support for M dimensions to GDAL "POINT" Geometries.

Copy link
Member

@ngnpope ngnpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see this addition 👍🏻

django/contrib/gis/gdal/geometries.py Outdated Show resolved Hide resolved
django/contrib/gis/gdal/geometries.py Outdated Show resolved Hide resolved
django/contrib/gis/gdal/geometries.py Outdated Show resolved Hide resolved
django/contrib/gis/gdal/geometries.py Outdated Show resolved Hide resolved
django/contrib/gis/gdal/geometries.py Outdated Show resolved Hide resolved
tests/gis_tests/gdal_tests/test_geom.py Outdated Show resolved Hide resolved
tests/gis_tests/gdal_tests/test_geom.py Outdated Show resolved Hide resolved
tests/gis_tests/gdal_tests/test_geom.py Outdated Show resolved Hide resolved
tests/gis_tests/gdal_tests/test_geom.py Outdated Show resolved Hide resolved
docs/releases/5.1.txt Outdated Show resolved Hide resolved
@smithdc1 smithdc1 force-pushed the the_fourth_dimension branch 2 times, most recently from 703a4ef to 78006d2 Compare January 13, 2024 15:15
@smithdc1 smithdc1 marked this pull request as ready for review January 13, 2024 16:26
@smithdc1
Copy link
Member Author

This PR is to add support for "M" Geometries. It also adds support for "M" dimensions to "POINT" so that we have something to test.

I'd like to focus this PR on reviewing the Python bindings and the API. I propose that adding support for the "M" dimension to other GEO_CLASSES is a follow up PR.

@smithdc1 smithdc1 force-pushed the the_fourth_dimension branch 3 times, most recently from 588e633 to 07ae979 Compare January 24, 2024 20:02
@felixxm felixxm self-assigned this Jan 24, 2024
@felixxm felixxm changed the title Refs #35058 -- Added support for M dimensions to GDAL Point geometries. Refs #35058 -- Added support for measured geometries to GDAL Point. Jan 25, 2024
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smithdc1 Thanks 👍

I pushed small edits to a release note.

Co-authored-by: Nick Pope <nick@nickpope.me.uk>
@felixxm felixxm merged commit 3f6d939 into django:main Jan 25, 2024
35 checks passed
@smithdc1 smithdc1 deleted the the_fourth_dimension branch January 25, 2024 08:53
@ngnpope
Copy link
Member

ngnpope commented Jan 25, 2024

Thanks David 👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants