Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #35117 -- Added support for the hectare unit in Area. #17739

Merged
merged 1 commit into from Jan 17, 2024

Conversation

alexisig
Copy link
Contributor

@alexisig alexisig commented Jan 15, 2024

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

@alexisig alexisig force-pushed the feat-measure-hectare branch 2 times, most recently from 206f959 to a0fc142 Compare January 15, 2024 23:06
@felixxm
Copy link
Member

felixxm commented Jan 16, 2024

@alexisig Thanks for this patch 👍 All new features require an accepted ticket, please create one (check out e.g. ticket-30341).

@alexisig alexisig marked this pull request as ready for review January 16, 2024 07:46
@alexisig
Copy link
Contributor Author

@felixxm Thank you for the pointer!

@alexisig alexisig force-pushed the feat-measure-hectare branch 2 times, most recently from 6ecd98f to 8ad19de Compare January 16, 2024 11:13
@felixxm felixxm changed the title Add hectare to area measure units Fixed #35117 -- Added support for the hectare unit in Area. Jan 16, 2024
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexisig Thanks 👍 Welcome aboard ⛵

I pushed small edits to docs.

@felixxm felixxm merged commit c7e986f into django:main Jan 17, 2024
35 checks passed
@felixxm
Copy link
Member

felixxm commented Jan 17, 2024

@alexisig Great timing! You're Django contributor no. 2500!

https://fosstodon.org/@felixxm/111769552802139711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants