Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final steps for adding author and keyword search #1320

Closed
daveverwer opened this issue Oct 25, 2021 · 2 comments · Fixed by #1574
Closed

Final steps for adding author and keyword search #1320

daveverwer opened this issue Oct 25, 2021 · 2 comments · Fixed by #1574
Projects
Search Enhancements

Comments

@daveverwer
Copy link
Member

We’re so close to this feature! @finestructure and I chatted through the last couple of bits this morning and here’s a list:

  • Search should return multiple matches for authors from a query:
    • We spoke about using some kind of string distance function for ordering of these results. From looking at the documentation, the “Levenshtein” method that Postgres supports might be a good primary ordering, maybe with a number of packages as a secondary sort order.
  • Search should return multiple matches for keywords from a query:
    • Ordered by number of packages with that tag attached
    • If we can pull the number out as well, we should. We can display it next to the tag.

There’s also #1194 but I’m not sure I understand that issue. Aren’t the package’s keywords where we’re pulling this single keyword result from? If it doesn’t match against keywords from a package, where are the keywords coming from?
@finestructure
Copy link
Member

What the issue is saying is that we're not currently matching against a package's keyword for the package search. I.e. if you search for foo and foo only appears as a package's topic (keyword), it would not show up in the package search result, only among the keywords.

@daveverwer
Copy link
Member Author

Ah yes, that makes sense now you explain it like that. This will be enhanced by #1244 too.

@daveverwer daveverwer mentioned this issue Feb 21, 2022
Merged
@daveverwer daveverwer moved this from To do to In progress in Search Enhancements Mar 8, 2022
@daveverwer daveverwer moved this from In progress to Done in Search Enhancements Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Search Enhancements
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable author and keyword search results on prod SwiftPackageIndex/SwiftPackageIndex-Server
2 participants
@daveverwer @finestructure