Fixed #35350 -- Fixed save() with pk set on models with GeneratedFields. #18058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charettes
approved these changes
Apr 8, 2024
Comment on lines
+1066
to
+1070
| non_pks_non_generated = [ | ||
| f | ||
| for f in meta.local_concrete_fields | ||
| if not f.primary_key and not f.generated | ||
| ] |
There was a problem hiding this comment.
This doesn't have to done here as this is meant as a non-invasive backport but since non_pks_non_generated is only used for containment checks and doesn't need to preserve ordering it might be a good candidate to use a set instead of a list.
There was a problem hiding this comment.
It could also be cached up on Options, it doesn’t need regenerating on every save() call.
|
Note that I have just finished testing this against the test project from @matthewhegarty (thank you for proving that ⭐) and this works for me there too. 👍 |
Thanks Matt Hegarty for the report and Simon Charette and Natalia Bidart for the reviews. Regression in f333e35.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks Matt Hegarty for the report.
Regression in f333e35.
Trac ticket number
ticket-35350
Checklist
mainbranch.