Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sign up endpoint for link with email password #11925

Merged
merged 13 commits into from Oct 13, 2023
Merged

Use sign up endpoint for link with email password #11925

merged 13 commits into from Oct 13, 2023

Conversation

renkelvin
Copy link
Contributor

@renkelvin renkelvin commented Oct 11, 2023 •
edited by paulb777

Fix #11911

@renkelvin
Copy link
Contributor Author

Working on fixing the ci.

@google-oss-bot
Copy link

google-oss-bot commented Oct 13, 2023 •
edited

Coverage Report 1

Affected Products

  • FirebaseAuth-iOS-FirebaseAuth.framework

    Overall coverage changed from 68.81% (62ae09c) to 68.54% (43d2e49) by -0.27%.

    FilenameBase (62ae09c)Merge (43d2e49)Diff
    FIRAuth.m83.67%83.68%+0.00%
    FIRAuthKeychainServices.m58.80%59.66%+0.86%
    FIRSignUpNewUserRequest.m95.92%96.30%+0.38%
    FIRUser.m71.07%69.50%-1.57%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LLzTg7ZmLL.html

prameshj
prameshj reviewed Oct 13, 2023
View reviewed changes
FirebaseAuth/Sources/User/FIRUser.m Outdated Show resolved Hide resolved
FirebaseAuth/Sources/User/FIRUser.m Outdated Show resolved Hide resolved
FirebaseAuth/Tests/Unit/FIRSignUpNewUserRequestTests.m Outdated Show resolved Hide resolved
@paulb777 paulb777 added this to the 10.17.0 - M139 milestone Oct 13, 2023
paulb777
paulb777 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog.

Can this PR be marked as fixing #11911?

@renkelvin
Copy link
Contributor Author

Please add a changelog.

Can this PR be marked as fixing #11911?

Yeah.

@renkelvin renkelvin linked an issue Oct 13, 2023 that may be closed by this pull request
Anonymous Auth Verify Can't Connect Account for Email / Password #11911
Closed
prameshj
prameshj approved these changes Oct 13, 2023
View reviewed changes
Copy link

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include any end to end testing that was done. Thanks!

@renkelvin renkelvin merged commit b7fd169 into master Oct 13, 2023
49 checks passed
@renkelvin renkelvin deleted the link-email branch October 13, 2023 23:56
renkelvin pushed a commit that referenced this pull request Oct 17, 2023
Revert "Use sign up endpoint for link with email password (#11925)"
517d816 
This reverts commit b7fd169.
@renkelvin renkelvin mentioned this pull request Oct 17, 2023
Merged
@paulb777 paulb777 mentioned this pull request Oct 18, 2023
Closed
@renkelvin renkelvin restored the link-email branch October 26, 2023 18:10
renkelvin pushed a commit that referenced this pull request Nov 1, 2023
Use sign up endpoint for link with email password (resubmit #11925) (#…
6673e7c 
…12009)
@firebase firebase locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@prameshj prameshj prameshj approved these changes

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
10.17.0 - M139
Development

Successfully merging this pull request may close these issues.

Anonymous Auth Verify Can't Connect Account for Email / Password
4 participants
@renkelvin @google-oss-bot @paulb777 @prameshj