Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #35058 -- Added support for measured geometries to GDAL Polygon. #17800

Merged
merged 1 commit into from Jan 31, 2024

Conversation

smithdc1
Copy link
Member

No description provided.

@@ -689,7 +689,7 @@ def test_geometry_types(self):
("Triangle M", 2017, False),
("Point ZM", 3001, True),
("LineString ZM", 3002, True),
("Polygon ZM", 3003, False),
("Polygon ZM", 3003, True),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smithdc1 Are you going to send another 11 PRs for all ZM geometry types? 🙃 just asking 🥲

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question!

The remaining items that are currently supported are all variations of GeometryCollection so was going to do that in one go. I'm not expecting there to be any API changes with those, they should 'just work'™️

As I'm expecting those to be similar to Polygon's (that is, just adding them to GEO_CLASSES) shall I add that as part of this PR?

Then there's new types (circular geometries) which I think is a separate PR as that'll add new bindings to the c library. I'm preping a larger PR for that then we can discuss if we merge that in chunks like with #17696

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I'm expecting those to be similar to Polygon's (that is, just adding them to GEO_CLASSES) shall I add that as part of this PR?

Already merged 😅 Please submit the next one.

@felixxm felixxm changed the title Refs #35058 -- Added support for measured geometries to GDAL Polygon. Refs #35058 -- Confirmed support for GDAL Polygon measured geometries. Jan 31, 2024
@felixxm felixxm changed the title Refs #35058 -- Confirmed support for GDAL Polygon measured geometries. Refs #35058 -- Added support for measured geometries to GDAL Polygon. Jan 31, 2024
@felixxm felixxm merged commit d3922e9 into django:main Jan 31, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants