Fixed #36177 -- Added a trailing newline to JSON serializer. #19232
+23
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahboyce
reviewed
Mar 7, 2025
sarahboyce
force-pushed
the
fixtures-newline
branch
from
eba6ec3 to
acde0f3
Compare
sarahboyce
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-36177
Branch description
Adds a trailing newline at the end of JSON serialization regardless of the
indentoption.I'm not 100% sure about this implementation. There are maybe cases where you really want to save that extra byte over the network, in the occasional case where it matters. So I wondered if maybe I should add this to
dumpdata, which would also fix this issue for other serializers, but it felt a bit like the wrong place to do it. But it may be the right place 🤷🏻Checklist
mainbranch.