Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #35599 -- Added ColorInput widget #18413

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

arjunomray
Copy link
Contributor

Trac ticket number

ticket-35599

Branch description

Added a form widget to render <input type='color' ... > widget

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

Sorry, something went wrong.

Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @arjunomray ⭐ I have minor comments

@arjunomray
Copy link
Contributor Author

@sarahboyce Thanks for the review, I have made the required changes.

Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates! Can you also resolve the merge conflicts?

@arjunomray
Copy link
Contributor Author

Sure, on it

@sarahboyce sarahboyce changed the title Fixed #35599 - Add ColorInput widget Fixed #35599 -- Added ColorInput widget Aug 2, 2024
Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @arjunomray - welcome onboard!

@sarahboyce sarahboyce merged commit 946c3cf into django:main Aug 2, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants