Hi @rookiejava, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, DNFBOT;

I'm expecting to see a veeeeery long discussion on this PR. Should I start ?

So I start...

FFA500 is yellowish. According to wikipedia, Orange is FF7F00. and this color profiled monitor tend to agree...

There's also a ColorTypeConverter that speeds up xaml parsing of Colors. Orange should be in there too.
Also, it misses the documentation. I'd define it as:

ORANGE. This is Orange, according to me. Some says it's a bit yellowish, but who cares?

Well, this is Orange color that we already have in .NET IIRC.

🍿

On Wed, 10 Aug 2016, 7:39 PM Stephane Delcroix notifications@github.com
wrote:

So I start...

FFA500 is yellowish. According to wikipedia, Orange is FF7F00. and this
color profiled monitor tend to agree...

There's also a ColorTypeConverter that speeds up xaml parsing of Colors.
Orange should be in there too.
Also, it misses the documentation. I'd define it as:

ORANGE. This is Orange, according to me. Some says it's a bit yellowish,
but who cares?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#290 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHxeRoUyNv_Ag1SAKS1WvLagd3DY8Noks5qeZxUgaJpZM4Jgz0x
.

@StephaneDelcroix Thank you for your time and effort to this matter. Wikipedia uses a normalized set of color coordinate systems in the color Information Box. It means that color coordinate ranges are a matter of designer choice and there is no universal standard range for many color spaces (though some ranges may be prevalent).

In this PR, I referred to Web color table. (All predefined color values in Xamarin.Forms are exactly same with Web color table.)

• https://en.wikipedia.org/wiki/Web_colors#Color_table
• http://www.w3schools.com/colors/colors_hex.asp

What is your reference color coordinate system? If you just want to follow Wikipedia, please make new PR to fix current Color.Lime value to #BFFF00 from #00FF00. - https://en.wikipedia.org/wiki/Lime_(color)
Also, please don't forget modify documentation as below:

LIME. This is Lime, according to me. Some says it's a bit reddish, but who cares?

I also thank you for your comment about ColorTypeConverter. I've updated patch.

Can the colors be aligned with .NET Framework colors? In this case, #FFA500 is the correct value.

https://msdn.microsoft.com/en-us/library/system.drawing.color.orange(v=vs.110).aspx

Since Xamarin is very deeply integrated with Microsoft, as a programmer, I'd expect .NET colors.

@adrianknight89 Thanks for your comment :-).

thanks for the fix in the converter, and the doc addition
👍

Hi, can you rebase in a single commit ?

Thanks

no need

this has been merged. Thanks for this @rookiejava. Sorry for the trolling, that was too tempting, I wasn't able to resists 😃