New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.4] Images in large thumbnails and inline editor previews are cropped. #5515
Comments
I think a case can be made for having both options in the CMS, show original aspect ratio and the cropped version, with the ability to toggle between them. Seeing as an image can often live as multiple different sizes/transforms when finally rendered on the site, the cropped version is nice because you can see where Craft will center it up for the transform. That's more useful in some cases, less so in others. If you have a portrait shot of people, for example, it's a quick indication that you also need to update the focus point or you might marie antoinette someone. ;) Similar to #5518... |
@RitterKnightCreative I agree that it's a good feature request to be able to see how the cropped version of an image would look. But if this change was meant to solve that, I think it's a pretty bad solution. It only partly solves the problem, seeing an image cropped to a square is only barely useful if the final image is suppose to be cropped for 16:9. And removing the option for authors to see the original aspect ratio of the image, as intended by the photographer/art director, is a massive downside. What would be a better solution would be to tie the cropping to the Asset field through settings. If it was possible to define a custom crop ratio (along with "no crop", ie "fit") in an Asset field's settings, and that crop showed up in the thumbnails on the field when you'd selected it, that'd be pretty amazing. And, if "fit" was used in the asset selection modals and the assets element index, everyone would be happy. |
I find this to be a backwards step in Craft's image asset workflow. I work with a lot of mixed ratio images and I need to be able to see at a glance the ratio of an image before selecting it (portrait book covers, and screenshots at 4:3 ratio and 16:9 ratio for example). I can see that cropped square images make for attractive grids, but in practice they aren't that useful for content-editors. So it would be great if Craft could provide a way to configure this, otherwise it's going to be pretty painful for us to use this going forward. |
I created a small plugin which fixes this while we wait for 3.5: |
We do a lot of work on numerous client sites that have 1000's of images that are imported into Craft every day and use all sorts of aspect ratios (social media images, broadcast images). Upgrading any of those sites to Craft 3.4 would be a disaster because of these uniformly square cropped images alone. The editors would be helpless choosing from 20+ similar thumbnails, looking for a certain 16:9, for example. |
I changed my mind on how we should be handling small thumbnails. Showing them at the correct aspect ratio isn’t really the end of the world. So I was able to implement the change for 3.4 with significantly less work than what I had done on the 3.5 branch. Will be in the next 3.4 release. To get the fix early, change your "require": {
"craftcms/cms": "dev-develop#8f6e9e8945d4df9627f0237dd47b0e66e4d52541 as 3.4.20",
"...": "..."
} Or if you’re already running Craft 3.5 Beta, then change your Then run |
Craft 3.4.21 is out now with this change. |
Description
In versions prior to 3.4, images were fitted into the large thumbnail containers and the preview area of the inline editor. In 3.4 they're cropped, making it impossible for users to know what the original format of the image is, when picking an asset.
In Craft 3.3:
In Craft 3.4:
The only way to see the actual format of the image in 3.4, is by opening the full image editor, or going to the edit asset page and clicking preview.
Although this makes the images look better in the said contexts, I think this is a major step-back AX-wise. It's essential for the author to know the original and intended format of an image, to make good calls on which image to use when authoring content.
Please make it fit!
Steps to reproduce
Additional info
The text was updated successfully, but these errors were encountered: