New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Xaml] Support native view declaration in Xaml #266
Conversation
|
else | ||
{ | ||
} | ||
else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change in this, unnecessary diff
7e8d5f2
to
ef35a36
Compare
23e2832
to
e4ef5ed
Compare
37a9fef
to
6703f77
Compare
If you review this, review only the 2nd commit. the first is part of another PR |
xmlns:ios="clr-namespace:UIKit;assembly=Xamarin.iOS;targetPlatform=iOS" | ||
xmlns:androidWidget="clr-namespace:Android.Widget;assembly=Mono.Android;targetPlatform=Android" | ||
xmlns:formsandroid="clr-namespace:Xamarin.Forms;assembly=Xamarin.Forms.Platform.Android;targetPlatform=Android" | ||
xmlns:win="clr-namespace:Windows.UI.Xaml.Controls;assembly=Windows, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null, ContentType=WindowsRuntime;targetPlatform=Windows" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notice the targetPlatform
on these 4 lines. notice the cumbersome assembly name for uwp as well, but that's required to get it working
Allows including Native views directly in xaml. Support for ios, android, UWP
6703f77
to
57690aa
Compare
Allows including Native views directly in xaml. Support for ios, android, UWP
Description of Change
With this PR, the following Xaml is valid, and works as expected:
That means 2 things:
Bugs Fixed
None
API Changes
None
Behavioral Changes
None
PR Checklist