Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various code logic corrections (without API changes). #198

Closed
wants to merge 2 commits into from

Conversation

Hybris95
Copy link

@Hybris95 Hybris95 commented May 27, 2016

Description of Change

Corrections after passing a PVS-Studio on the Project
No tests because no test environment yet just newly forking the project.

Some corrections may be implemented later (View.cs & LayoutAlignmentExtensions.cs).
Tests needs to be done also.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

Some corrections may be implemented later (View.cs & LayoutAlignmentExtensions.cs).
Tests needs to be done also.
@dnfclas
Copy link

dnfclas commented May 27, 2016

Hi @Hybris95, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@Hybris95
Copy link
Author

Last PR : #194

@@ -88,5 +89,5 @@ static bool ValidateItemTemplate(BindableObject b, object v)

return !(lv.CachingStrategy == ListViewCachingStrategy.RetainElement && lv.ItemTemplate is DataTemplateSelector);
}
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random whitespace change?

@jassmith
Copy link

Changes to absolute layout break unit tests

}
else
{
// Only width is auto
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we're loosing a case here when !heightIsProportional

@rmarinho
Copy link
Member

rmarinho commented Jun 8, 2016

Please re-open when addressing comments, coding style, and unit tests failures.

@rmarinho rmarinho closed this Jun 8, 2016
@Hybris95
Copy link
Author

Please do it yourself, I have no interest doing so. Fix yourself the bugs I pointed out if you wish to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants