New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various code logic corrections (without API changes). #198
Conversation
Some corrections may be implemented later (View.cs & LayoutAlignmentExtensions.cs). Tests needs to be done also.
Hi @Hybris95, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
Last PR : #194 |
@@ -88,5 +89,5 @@ static bool ValidateItemTemplate(BindableObject b, object v) | |||
|
|||
return !(lv.CachingStrategy == ListViewCachingStrategy.RetainElement && lv.ItemTemplate is DataTemplateSelector); | |||
} | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random whitespace change?
Changes to absolute layout break unit tests |
} | ||
else | ||
{ | ||
// Only width is auto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we're loosing a case here when !heightIsProportional
Please re-open when addressing comments, coding style, and unit tests failures. |
Please do it yourself, I have no interest doing so. Fix yourself the bugs I pointed out if you wish to. |
Description of Change
Corrections after passing a PVS-Studio on the Project
No tests because no test environment yet just newly forking the project.
Some corrections may be implemented later (View.cs & LayoutAlignmentExtensions.cs).
Tests needs to be done also.
PR Checklist