Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rubocop/rubocop-rspec
base: v1.23.0
Choose a base ref
...
head repository: rubocop/rubocop-rspec
compare: v1.24.0
Choose a head ref
  • 16 commits
  • 19 files changed
  • 4 contributors

Commits on Feb 23, 2018

  1. Let Rails/HttpStatus cop always depend on Rack 

    If Rack isn't loaded, the cop just isn't available.
    @bquorning
    bquorning committed Feb 23, 2018
    Copy the full SHA
    3e4d6e6 View commit details
    Browse the repository at this point in the history

  2. [Fix 560] Allow custom HTTP status codes 

    When Rails/HttpStatus is configured to use `symbolic` style, a custom HTTP
status code (e.g. 550) that couldn't be found in Rack's `SYMBOL_TO_STATUS_CODE`
hash would result in an error:

    ^^^ Prefer `nil` over `550` to describe HTTP status code.
    @bquorning
    bquorning committed Feb 23, 2018
    Copy the full SHA
    d60334b View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2018

  1. Merge pull request #561 from backus/bquorning_http_status-bugfix 

    Bugfix for custom HTTP status codes
    @bquorning
    bquorning committed Feb 24, 2018
    Copy the full SHA
    c52c41f View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2018

  1. Handle empty block in static attribute cop

    @abrom
    abrom committed Feb 26, 2018
    Copy the full SHA
    7258037 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2018

  1. Merge pull request #564 from abrom/fix-static-empty-block 

    [FIX] Handle empty block in FactoryBot/StaticAttributeDefinedDynamically
    @bquorning
    bquorning committed Feb 27, 2018
    Copy the full SHA
    9630319 View commit details
    Browse the repository at this point in the history

  2. Fix false positive in FactoryBot/DynamicAttributeDefinedStatically … 

    …when a before/after callback has a symbol proc argument.
    @abrom
    abrom committed Feb 27, 2018
    Copy the full SHA
    9119242 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2018

  1. Merge pull request #562 from abrom/fix-dynamic-callback-proc 

    [FIX] False positive in `FactoryBot/DynamicAttributeDefinedStatically`
    @bquorning
    bquorning committed Feb 28, 2018
    Copy the full SHA
    5b4177f View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2018

  1. Bump to use RuboCop v0.53.0

    @bquorning
    bquorning committed Mar 5, 2018
    Copy the full SHA
    644e681 View commit details
    Browse the repository at this point in the history

  2. Include new RangeHelp module where used

    @bquorning
    bquorning committed Mar 5, 2018
    Copy the full SHA
    b823eab View commit details
    Browse the repository at this point in the history

  3. Fix Style/ExpandPathArguments

    @bquorning
    bquorning committed Mar 5, 2018
    Copy the full SHA
    8d28200 View commit details
    Browse the repository at this point in the history

  4. Fix Naming/UncommunicativeMethodParamName

    @bquorning
    bquorning committed Mar 5, 2018
    Copy the full SHA
    02bfe51 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #567 from backus/rubocop-0.53.0 

    Fix RuboCop v0.53.0 compatibility
    @bquorning
    bquorning committed Mar 5, 2018
    Copy the full SHA
    0946e68 View commit details
    Browse the repository at this point in the history

  6. Fix changelog 

    [ci skip]
    @bquorning
    bquorning committed Mar 5, 2018
    Copy the full SHA
    dc6b832 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2018

  1. Merge pull request #568 from backus/fix-changelog 

    Fix changelog
    @Darhazer
    Darhazer committed Mar 6, 2018
    Copy the full SHA
    0d10297 View commit details
    Browse the repository at this point in the history

  2. Bump version to 1.24.0

    @bquorning
    bquorning committed Mar 6, 2018
    Copy the full SHA
    b5dab93 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #570 from rubocop-rspec/bump-1.24.0 

    Bump version to 1.24.0
    @bquorning
    bquorning committed Mar 6, 2018
    Copy the full SHA
    e51fc4a View commit details
    Browse the repository at this point in the history